Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(explorer): add previous and next block navigation to block page #864

Merged
merged 1 commit into from
Dec 18, 2024
Merged

feat(explorer): add previous and next block navigation to block page #864

merged 1 commit into from
Dec 18, 2024

Conversation

telestrial
Copy link
Contributor

@telestrial telestrial commented Dec 17, 2024 •
edited
Loading

Screenshot 2024-12-17 at 1.36.12 PM.png

I played with the positioning of these two buttons (next to block height, center, etc) and whether to write out "previous block" and "next block" or not. I settled with this and a tooltip. Included catching the < 1 and > current block height cases.

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 8:53pm
explorer-zen ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 8:53pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hostd ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 8:53pm
renterd ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 8:53pm
website ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 8:53pm

@telestrial Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@telestrial telestrial marked this pull request as ready for review December 17, 2024 18:38
alexfreska
alexfreska reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@alexfreska alexfreska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, just one minor change.

apps/explorer/components/Block/index.tsx Outdated Show resolved Hide resolved
@telestrial telestrial force-pushed the 12-17-feat_explorer_add_previous_and_next_block_navigation_to_block_page branch from 51c8feb to f9835f3 Compare December 17, 2024 20:47
@telestrial Graphite App
Copy link
Contributor Author

telestrial commented Dec 18, 2024 •
edited
Loading

Merge activity

  • Dec 18, 11:08 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 18, 11:08 AM EST: A user merged this pull request with Graphite.

@telestrial telestrial merged commit 61b3dd8 into main Dec 18, 2024
37 checks passed
@telestrial telestrial deleted the 12-17-feat_explorer_add_previous_and_next_block_navigation_to_block_page branch December 18, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfreska alexfreska alexfreska approved these changes

@n8maninger n8maninger Awaiting requested review from n8maninger

Assignees

@telestrial telestrial

Labels
None yet
Projects
Sia
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@telestrial @alexfreska